the message "\$CATALINA_PID was set but the specified file does not exist. Is Tomcat running? Stop

Bug 51309 -Patch to better stop support with CATALINA_PID

Status:RESOLVED FIXED  Product:Tomcat 6Component:Native:IntegrationVersion:6.0.32Platform:All Linux Importance:P2 normal (vote)Target Milestone:defaultAssigned To:Tomcat Developers Mailing List URL:Keywords:  Depends on:Blocks: Show dependency tree

 

Reported:2011-06-01 15:33 UTC by Caio CezarModified:2011-06-14 11:48 UTC (History)CC List:0 users

  

---

Attachments Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

 

DescriptionCaio Cezar2011-06-01 15:33:13 UTC

When using the CATALINA_PID variable the catalina.sh stop action verify if thePID file is empty (-s $CATALINA_PID) and after that verify if the file is afile (-f $CATALINA_PID). But if the file doesn't exist the "test -s" return 1consequently the message "\$CATALINA_PID was set but the specified file doesnot exist. Is Tomcat running? Stop aborted." is never printed.I made a patch to fix this, but what you need to do is just invert "-s" and"-f".PATCH:--- catalina.sh.bkp    2011-06-01 12:02:07.541350449 -0300+++ catalina.sh    2011-06-01 12:02:37.916302955 -0300@@ -403,19 +403,19 @@   fi   if [ ! -z "$CATALINA_PID" ]; then-    if [ -s "$CATALINA_PID" ]; then-      if [ -f "$CATALINA_PID" ]; then+    if [ -f "$CATALINA_PID" ]; then+      if [ -s "$CATALINA_PID" ]; then         kill -0 `cat "$CATALINA_PID"` >/dev/null 2>&1         if [ $? -gt 0 ]; then           echo "PID file found but no matching process was found. Stopaborted."           exit 1         fi       else-        echo "\$CATALINA_PID was set but the specified file does not exist. IsTomcat running? Stop aborted."-        exit 1+        echo "PID file is empty and has been ignored."       fi     else-      echo "PID file is empty and has been ignored."+      echo "\$CATALINA_PID was set but the specified file does not exist. IsTomcat running? Stop aborted."+      exit 1     fi   fi

Comment 1Mark Thomas2011-06-02 20:11:43 UTC

Thanks for the patch.For future reference patches work best as attachments the lines are likely toget wrapped if you paste them in the comments box.The patch has been applied to 7.0.x and will be included in 7.0.15 onwards.I have proposed the patch for 6.0.x.

Comment 2Caio Cezar2011-06-03 10:55:10 UTC

(In reply to comment #1)> Thanks for the patch.> > For future reference patches work best as attachments the lines are likely to> get wrapped if you paste them in the comments box.> > The patch has been applied to 7.0.x and will be included in 7.0.15 onwards.> > I have proposed the patch for 6.0.x.Thanks Mark

Comment 3Mark Thomas2011-06-14 11:48:54 UTC

This has been fixed in 6.0.x and will be included in 6.0.33 onwards.