Code Review的一些注意事项(英文版)
来源:互联网 发布:如何提高淘宝网 编辑:程序博客网 时间:2024/04/27 15:41
The code review check list
1. Does the task/code for the right project?
2. Does the task created correctly? take care of the Name and Description
3. General Code Smoke Test
3.1 Pass build, No Error, No warning introduced by new added code
3.2 Execute as expected
4. Is the code commented? The comments is for reviewer but not for the coder
5. Error Handling
5.1 Are errors properly handled each time a function returns?
5.2 Are resources and memory released in all error paths?
5.3 is the function caller notified when an error is detected?
6. Is allocated memory freed? Even in the error handling path
7. Are all global variables thread-safe?
8. Are locks released in the same order they are obtained?
9. is there any possible deadlock or lock contention?
10. Is there infinite loop?
11. Do recursive functions run within a reasonable amount of stack space?
12. Can the code be optimized?
13. Was the optimization really needed? If it make the code more complex
14. Is the code doing busy waits instead of using synchronization mechanisms or timer events?
15. Are function parameters explicitly verified in the code?
16. Are arrays explicitly checked for out-of-bound indexed?
17. Are variable initialized before they are used?
18. Does a fix made to a function change the behavior of caller functions?
19. Does the bug fix correct all the occurrences of the bug?
20. Is the code doing signed/unsigned conversions? Can sign completion cause problems? Check all unsigned to signed conversions: Can overflow occur?
阅读(5) | 评论(0) | 转发(0) |
上一篇:ARM的中断和时钟中断
下一篇:将博客搬至CSDN
- Android之开发环境搭建
- Android自定义View的实现...
- AndroidManifest.xml配置文件...
- Android源码调试方法详解...
- 不用vs和cygwin!Eclipse+cdt...
- 谁能够帮我解决LINUX 2.6 10...
- 现在的博客积分不会更新了吗?...
- shell怎么读取网页内容...
- ssh等待连接的超时问题...
- curl: (56) Recv failure: Con...
- Code Review的一些注意事项(英文版)
- Code Review的注意事项
- 关于代码审查(Code Review)的一些建议
- Java Code review 一些原则的原因探讨
- CD review的注意事项
- sclc的code review
- Code Review的要点
- git的code review
- Code Review的重要性
- code review的思考
- code review的看法
- code review (一)
- Code Review(一)
- Code Review(二)
- Code Review(二)
- Code Review(一)
- Code Review 之后的总结
- 理解code review的含义
- Leetcode---Validate Binary Search Tree
- Leetcode---Path Sum II
- Leetcode---Path Sum
- Leetcode---Binary Tree Maximum Path Sum
- ARM的中断和时钟中断
- Code Review的一些注意事项(英文版)
- 【Visual C++】游戏开发笔记三十 DirectX11 2D纹理映射知识全攻略
- [leetcode 42] Trapping Rain Water
- OC中内存管理问题之引用计数
- socketpair
- Vs2013在Linux开发中的应用(27):线程列表
- MySQL与Oracle 差异比较之五存储过程
- FusionCharts参数的详细说明和功能特性
- Leetcode -- Container With Most Water